lkml.org 
[lkml]   [2022]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Fix perf's libperf_print callback
Em Fri, Apr 08, 2022 at 04:26:25PM +0300, Adrian Hunter escreveu:
> eprintf does not expect va_list as the 4th parameter.
> Use veprintf because it does.

You forgot to add this:

Fixes: 428dab813a56ce94 ("libperf: Merge libperf_set_print() into libperf_init()")

Please consider doing it next time.

Thanks, applied.

- Arnaldo

> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/perf.c b/tools/perf/perf.c
> index 2f6b67189b42..6aae7b6c376b 100644
> --- a/tools/perf/perf.c
> +++ b/tools/perf/perf.c
> @@ -434,7 +434,7 @@ void pthread__unblock_sigwinch(void)
> static int libperf_print(enum libperf_print_level level,
> const char *fmt, va_list ap)
> {
> - return eprintf(level, verbose, fmt, ap);
> + return veprintf(level, verbose, fmt, ap);
> }
>
> int main(int argc, const char **argv)
> --
> 2.25.1

--

- Arnaldo

\
 
 \ /
  Last update: 2022-04-09 17:17    [W:0.059 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site