Messages in this thread | | | Subject | Re: [PATCH V3] testing/selftests/mqueue: Fix mq_perf_tests to free the allocated cpu set | From | Shuah Khan <> | Date | Fri, 8 Apr 2022 12:30:23 -0600 |
| |
On 4/8/22 1:24 AM, Athira Rajeev wrote: > The selftest "mqueue/mq_perf_tests.c" use CPU_ALLOC to allocate > CPU set. This cpu set is used further in pthread_attr_setaffinity_np > and by pthread_create in the code. But in current code, allocated > cpu set is not freed. > > Fix this issue by adding CPU_FREE in the "shutdown" function which > is called in most of the error/exit path for the cleanup. There are > few error paths which exit without using shutdown. Add a common goto > error path with CPU_FREE for these cases. > > Fixes: 7820b0715b6f ("tools/selftests: add mq_perf_tests") > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > --- > Changelog: > From v2 -> v3: > Addressed review comment from Shuah Khan to add > common "goto" error path with CPU_FREE for few exit > cases. > From v1 -> v2: > Addressed review comment from Shuah Khan to add > CPU_FREE in other exit paths where it is needed >
Thank you. I will queue this up for Linux 5.18-rc3
thanks, -- Shuah
| |