Messages in this thread | | | Date | Fri, 8 Apr 2022 17:03:26 +0200 | Subject | Re: [PATCH v2] rtla: add a tag to avoid dereferring a NULL pointer | From | Daniel Bristot de Oliveira <> |
| |
Hi Wan
There is a typo in the subject, and it needs a capital letter after the ':'.
I suggest using something like:
rtla: Avoid record NULL pointer dereference
Do you mind sending a v3?
On 4/1/22 14:39, Wan Jiabing wrote: > Fix the following null/deref_null.cocci errors: > ./tools/tracing/rtla/src/osnoise_hist.c:870:31-36: ERROR: record is NULL but dereferenced. > ./tools/tracing/rtla/src/osnoise_top.c:650:31-36: ERROR: record is NULL but dereferenced. > ./tools/tracing/rtla/src/timerlat_hist.c:905:31-36: ERROR: record is NULL but dereferenced. > ./tools/tracing/rtla/src/timerlat_top.c:700:31-36: ERROR: record is NULL but dereferenced. > > "record" is NULL before calling osnoise_init_trace_tool. > Add a tag "out_free" to avoid dereferring a NULL pointer. > > Fixes: 51d64c3a1819 ("rtla: Add -e/--event support") > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Also adding:
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Thanks, -- Daniel
| |