Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 8 Apr 2022 16:17:16 +0200 | Subject | Re: [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver |
| |
On Fri, Apr 8, 2022 at 3:32 PM Daniel Thompson <daniel.thompson@linaro.org> wrote: > On Thu, Mar 31, 2022 at 05:44:55PM +0200, Arnd Bergmann wrote: > > There is some prior art for this sort of feature. AFAICT SGI UV has a > similar mechanism that can send an NMI-with-no-side-channel to the > kernel. The corresponding driver offers a range of actions using a > module parameter: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/platform/uv/uv_nmi.c#n180 > > I don't think a hardcoded 'c' makes any sense. With a hardcoded argument > it is just obfuscation. However it is certainly seems attractive to be > able to reuse handle_sysrq() to provide a more powerful set of actions.
How about a module parameter that allows picking a sysrq character then?
Arnd
| |