lkml.org 
[lkml]   [2022]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/2] staging: rtl8192u: replace ternary statement with if and assignment
    On Fri, Apr 08, 2022 at 06:15:14AM +0200, Julia Lawall wrote:
    >
    >
    > On Thu, 7 Apr 2022, Rebecca Mckeever wrote:
    >
    > > Replace ternary statement with an if statement followed by an assignment
    > > to increase readability and make error handling more obvious.
    > > Found with minmax coccinelle script.
    > >
    > > Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
    > > ---
    > > drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 4 +++-
    > > 1 file changed, 3 insertions(+), 1 deletion(-)
    > >
    > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
    > > index 78cc8f357bbc..9885917b9199 100644
    > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
    > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
    > > @@ -470,7 +470,9 @@ int ieee80211_wx_get_encode(struct ieee80211_device *ieee,
    > > return 0;
    > > }
    > > len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv);
    > > - erq->length = (len >= 0 ? len : 0);
    > > + if (len < 0)
    > > + len = 0;
    > > + erq->length = len;
    >
    > Maybe you could use max here?

    Dan said to not do this on based on the first submission :)

    \
     
     \ /
      Last update: 2022-04-08 07:14    [W:3.048 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site