Messages in this thread | | | Date | Fri, 8 Apr 2022 13:57:52 +0100 | Subject | Re: [PATCH 1/4] scsi: core: constify pointer to scsi_host_template | From | John Garry <> |
| |
On 08/04/2022 13:32, Krzysztof Kozlowski wrote: > On 08/04/2022 14:14, John Garry wrote: >> On 08/04/2022 11:30, Krzysztof Kozlowski wrote: >>> Several pointers to 'struct scsi_host_template' do not modify it, so >>> made them const for safety. >>> >> Is this standard practice? What is so special here? > This is standard practice and there is nothing special here. Pointers to > const are preferred because: > 1. They add safety if data is actually const. This is not yet the case, > but scsi_host_template allocation could be made const with some effort.
To me this seems better, but I think that some drivers might modify their scsi_host_template (so not possible)
> 2. The more const variables, the easier function contents and its impact > is to understand. This is actually the biggest benefit when dealing with > code touching different structures. > > In general, constifying is a common practice everywhere in the kernel.
Thanks, John
| |