lkml.org 
[lkml]   [2022]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V2 01/15] dt-bindings: cpufreq: mediatek: Add MediaTek CCI property
    From
    Date
    On Fri, 2022-04-08 at 10:10 +0200, Krzysztof Kozlowski wrote:
    > On 08/04/2022 06:58, Rex-BC Chen wrote:
    > > From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
    > >
    > > MediaTek Cache Coherent Interconnect (CCI) uses software devfreq
    > > module
    > > for scaling clock frequency and adjust voltage.
    > > The phandle could be linked between CPU and MediaTek CCI for some
    > > MediaTek SoCs, like MT8183 and MT8186.
    > > Therefore, we add this property in cpufreq-mediatek.txt.
    > >
    > > Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
    > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
    > > ---
    > > .../devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4
    > > ++++
    > > 1 file changed, 4 insertions(+)
    > >
    > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-
    > > mediatek.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-
    > > mediatek.txt
    > > index b8233ec91d3d..d1b3d430c25c 100644
    > > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-
    > > mediatek.txt
    > > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-
    > > mediatek.txt
    > > @@ -20,6 +20,10 @@ Optional properties:
    > > Vsram to fit SoC specific needs. When absent, the
    > > voltage scaling
    > > flow is handled by hardware, hence no software "voltage
    > > tracking" is
    > > needed.
    > > +- cci: MediaTek Cache Coherent Interconnect uses software devfreq
    > > module for scaling
    > > + clock frequency and adjust voltage.
    >
    > You need to describe the type. I am a bit confused whether this is a
    > cci
    > (so cci-control-port property?) or an interconnect (so interconnect
    > property)... It does not look like a generic property, so you need
    > vendor prefix.

    Hello Krzysztof,

    Thanks for your review.

    Yes, this cci is not arm's cci (cci-control-port property), and it's
    mediatek's cci. I will revise this name to "mtk-cci" in next version.

    >
    > > + For details, please refer to
    > > + Documentation/devicetree/bindings/devfreq/mtk-cci.yaml
    >
    > Such file does not exist.

    This mediatek cci is still upstreaming in this patch:
    message-id:20220408052150.22536-2-johnson.wang@mediatek.com

    Do you have suggestion that I should put this reference?
    Or I just remove it and describe the mediatek cci in detail?

    BRs,
    Rex
    >
    >
    > Best regards,
    > Krzysztof

    \
     
     \ /
      Last update: 2022-04-08 12:26    [W:4.446 / U:0.780 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site