Messages in this thread | | | Date | Fri, 8 Apr 2022 10:18:24 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH] net: phy: genphy_loopback: fix loopback failed when speed is unknown |
| |
On Thu, Apr 07, 2022 at 04:45:03PM +0200, Andrew Lunn wrote: > > Hi Andrew, > > The PHY we test is RTL8211F, it supports 10 half. This problem actually is, > > our board has MAC connected with PHY, when loopback test, packet flow is > > MAC->PHY->MAC, it needs speed of MAC and PHY should be same when they work. > > > > If PHY speed is unknown when PHY goes down, we will not set MAC speed in > > adjust_link interface. In this case, we hope that PHY speed should not be > > changed, as the old code of function genphy_loopback() before patch > > "net: phy: genphy_loopback: add link speed configuration". > > > > If PHY has never link, MAC speed has never be set in adjust_link interface, > > yeah, in this case, MAC and PHY may has different speed, and they can not work. > > I think we can accept this situation. > > > > I think it is general problem if there is MAC connected with PHY. > > Thanks for investigating. Looks like we are getting close the real > solution. And it is a generic problem, that the MAC and PHY might not > be using the same configuration. > > So it looks like if the link is down, or speed is UNKNOWN, we need to > set phydev->link true, speed 10, duplex half...
Hm, i was thinking, is it impossible to run loopback test on half duplex link. Do I missing something?
Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |