lkml.org 
[lkml]   [2022]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/4] device property: Allow error pointer to be passed to fwnode APIs
On Wed, Apr 06, 2022 at 08:05:23PM +0200, Michael Walle wrote:

...

> > + if (IS_ERR_OR_NULL(fwnode))
> > + return -ENOENT;
> > +
> > ret = fwnode_call_int_op(fwnode, get_reference_args, prop, nargs_prop,
> > nargs, index, args);
> > + if (ret == 0)
> > + return ret;
> >
> > - if (ret < 0 && !IS_ERR_OR_NULL(fwnode) &&
> > - !IS_ERR_OR_NULL(fwnode->secondary))
> > - ret = fwnode_call_int_op(fwnode->secondary, get_reference_args,
> > - prop, nargs_prop, nargs, index, args);
> > + if (IS_ERR_OR_NULL(fwnode->secondary))
> > + return -ENOENT;
>
> Doesn't this mean you overwrite any return code != 0 with -ENOENT?
> Is this intended?

Indeed, it would shadow the error code.
So, it should go with

if (IS_ERR_OR_NULL(fwnode->secondary))
return ret;

then.

> In any case:
> Tested-by: Michael Walle <michael@walle.cc>

Thanks!

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-04-07 17:31    [W:0.235 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site