lkml.org 
[lkml]   [2022]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v5 024/104] KVM: TDX: create/destroy VM structure
On Tue, Apr 05, 2022 at 02:44:04PM +0200,
Paolo Bonzini <pbonzini@redhat.com> wrote:

> > diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
> > index 6111c6485d8e..5c3a904a30e8 100644
> > --- a/arch/x86/kvm/vmx/main.c
> > +++ b/arch/x86/kvm/vmx/main.c
> > @@ -39,12 +39,24 @@ static int vt_vm_init(struct kvm *kvm)
> > ret = tdx_module_setup();
> > if (ret)
> > return ret;
> > - return -EOPNOTSUPP; /* Not ready to create guest TD yet. */
> > + return tdx_vm_init(kvm);
> > }
> > return vmx_vm_init(kvm);
> > }
> > +static void vt_mmu_prezap(struct kvm *kvm)
> > +{
> > + if (is_td(kvm))
> > + return tdx_mmu_prezap(kvm);
> > +}
>
> Please rename the function to explain what it does, for example
> tdx_mmu_release_hkid.

In the patch 021/104, you suggested flush_shadow_all_private().
Which do you prefer? flush_shadow_all_private or tdx_mmu_release_hkid.
--
Isaku Yamahata <isaku.yamahata@gmail.com>

\
 
 \ /
  Last update: 2022-04-08 02:54    [W:0.281 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site