Messages in this thread | | | Subject | Re: [RFC PATCH v5 047/104] KVM: x86/mmu: add a private pointer to struct kvm_mmu_page | From | Kai Huang <> | Date | Fri, 08 Apr 2022 10:53:11 +1200 |
| |
On Thu, 2022-04-07 at 15:52 +0200, Paolo Bonzini wrote: > On 4/7/22 01:43, Kai Huang wrote: > > > + if (kvm_gfn_stolen_mask(vcpu->kvm)) { > > Please get rid of kvm_gfn_stolen_mask(). > > > > Kai, please follow the other reviews that I have posted in the last few > days. > > Paolo >
Do you mean below reply?
"I think use of kvm_gfn_stolen_mask() should be minimized anyway. I would rename it to to kvm_{gfn,gpa}_private_mask and not return bool."
I also mean we should not use kvm_gfn_stolen_mask(). I don't have opinion on the new name. Perhaps kvm_is_protected_vm() is my preference though.
| |