Messages in this thread | | | Date | Wed, 6 Apr 2022 12:00:04 +0800 | Subject | Re: [PATCH 1/3] dt-bindings: clock: add binding for MA35D1 clock controller | From | Jacky Huang <> |
| |
On 2022/3/31 下午 02:34, Krzysztof Kozlowski wrote: > On 31/03/2022 08:29, Krzysztof Kozlowski wrote: >> On 31/03/2022 04:42, Jacky Huang wrote: >>> Add the dt-bindings header for Nuvoton MA35D1, that gets shared >>> between the clock controller and clock references in the dts. >>> >>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com> >>> --- >>> .../dt-bindings/clock/nuvoton,ma35d1-clk.h | 262 ++++++++++++++++++ >>> 1 file changed, 262 insertions(+) >>> create mode 100644 include/dt-bindings/clock/nuvoton,ma35d1-clk.h >>> >>> diff --git a/include/dt-bindings/clock/nuvoton,ma35d1-clk.h b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h >>> new file mode 100644 >>> index 000000000000..3634e5edcac5 >>> --- /dev/null >>> +++ b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h >>> @@ -0,0 +1,262 @@ >>> +/* SPDX-License-Identifier: GPL-2.0+ OR MIT */ >> Can you make it the same license as bindings? >> >>> +/* >>> + * Copyright (c) 2022 Nuvoton Technology Corporation. >>> + */ >>> + >>> +#ifndef __DT_BINDINGS_MA35D1_CLK_H >>> +#define __DT_BINDINGS_MA35D1_CLK_H >>> + >>> +/* Clock Sources */ >>> +/* External and Internal oscillator clocks */ >>> +#define HXT 0 >> One space after '#define'. Please do not introduce some non-Linux coding >> style. > You also ignored my comments from your v1 (because this is not v1...). > Do not resend without discussion or implementation. > > Best regards, > Krzysztof
Hi Krzysztof,
I am finding out the comments from all mails of this series and working on them. I will fix all the issues before sending the next version. So, the next version should be V3, right? I will add modification history "V1 -> V2" and "V2 -> V3" to [PATCH V3 0/3]. Is that OK?
Sincerely, Jacky
| |