Messages in this thread Patch in this message | | | Date | Wed, 6 Apr 2022 11:02:12 -0400 | From | Peter Xu <> | Subject | Re: [PATCH v8 15/23] mm/hugetlb: Handle pte markers in page faults |
| |
On Wed, Apr 06, 2022 at 09:37:00PM +0800, kernel test robot wrote: > Hi Peter, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on hnaz-mm/master] > [cannot apply to arnd-asm-generic/master linus/master linux/master v5.18-rc1 next-20220406] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/userfaultfd-wp-Support-shmem-and-hugetlbfs/20220405-100136 > base: https://github.com/hnaz/linux-mm master > config: s390-randconfig-r044-20220406 (https://download.01.org/0day-ci/archive/20220406/202204062154.2txNJyaf-lkp@intel.com/config) > compiler: s390-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/e7e7aaec811e2817cd169f0cc1d8f81bdf1f05c3 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Peter-Xu/userfaultfd-wp-Support-shmem-and-hugetlbfs/20220405-100136 > git checkout e7e7aaec811e2817cd169f0cc1d8f81bdf1f05c3 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > mm/hugetlb.c: In function 'hugetlb_fault': > >> mm/hugetlb.c:5678:13: error: implicit declaration of function 'huge_pte_none_mostly'; did you mean 'pte_none_mostly'? [-Werror=implicit-function-declaration] > 5678 | if (huge_pte_none_mostly(entry)) { > | ^~~~~~~~~~~~~~~~~~~~ > | pte_none_mostly > cc1: some warnings being treated as errors
Ah, the s390 stub was forgotten again, sorry. I hope someday s390 will start to include asm-generic/hugetlb.h like all the rest archs, because that's really from the gut feeling of how it should happen.. or the dir should be renamed to asm-generic-without-s390/. :(
An expected fix patch attached (to be squashed into patch "mm: Introduce PTE_MARKER swap entry").
Thanks,
-- Peter Xu From 8b84d7f6b86c30623208eff386b4f5169f1cb0db Mon Sep 17 00:00:00 2001 From: Peter Xu <peterx@redhat.com> Date: Wed, 6 Apr 2022 10:55:55 -0400 Subject: [PATCH] fixup! mm: Introduce PTE_MARKER swap entry
Signed-off-by: Peter Xu <peterx@redhat.com> --- arch/s390/include/asm/hugetlb.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/arch/s390/include/asm/hugetlb.h b/arch/s390/include/asm/hugetlb.h index be99eda87f4d..32c3fd6e878e 100644 --- a/arch/s390/include/asm/hugetlb.h +++ b/arch/s390/include/asm/hugetlb.h @@ -85,6 +85,11 @@ static inline int huge_pte_none(pte_t pte) return pte_none(pte); } +static inline int huge_pte_none_mostly(pte_t pte) +{ + return huge_pte_none(pte); +} + static inline int huge_pte_write(pte_t pte) { return pte_write(pte); -- 2.32.0
| |