lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0786/1126] driver core: dd: fix return value of __setup handler
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit f2aad54703dbe630f9d8b235eb58e8c8cc78f37d ]

    When "driver_async_probe=nulltty" is used on the kernel boot command line,
    it causes an Unknown parameter message and the string is added to init's
    environment strings, polluting them.

    Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc6
    driver_async_probe=nulltty", will be passed to user space.

    Run /sbin/init as init process
    with arguments:
    /sbin/init
    with environment:
    HOME=/
    TERM=linux
    BOOT_IMAGE=/boot/bzImage-517rc6
    driver_async_probe=nulltty

    Change the return value of the __setup function to 1 to indicate
    that the __setup option has been handled.

    Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
    Fixes: 1ea61b68d0f8 ("async: Add cmdline option to specify drivers to be async probed")
    Cc: Feng Tang <feng.tang@intel.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: "Rafael J. Wysocki" <rafael@kernel.org>
    Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
    Reviewed-by: Feng Tang <feng.tang@intel.com>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Link: https://lore.kernel.org/r/20220301041829.15137-1-rdunlap@infradead.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/base/dd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/base/dd.c b/drivers/base/dd.c
    index f47cab21430f..752a11d16e26 100644
    --- a/drivers/base/dd.c
    +++ b/drivers/base/dd.c
    @@ -810,7 +810,7 @@ static int __init save_async_options(char *buf)
    pr_warn("Too long list of driver names for 'driver_async_probe'!\n");

    strlcpy(async_probe_drv_names, buf, ASYNC_DRV_NAMES_MAX_LEN);
    - return 0;
    + return 1;
    }
    __setup("driver_async_probe=", save_async_options);

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 11:15    [W:4.688 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site