lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0741/1126] staging: r8188eu: fix endless loop in recv_func
    Date
    From: Martin Kaiser <martin@kaiser.cx>

    [ Upstream commit 1327fcf175fa63d3b7a058b8148ed7714acdc035 ]

    Fix an endless loop in recv_func. If pending_frame is not NULL, we're
    stuck in the while loop forever. We have to call rtw_alloc_recvframe
    each time we loop.

    Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
    Reported-by: Pavel Skripkin <paskripkin@gmail.com>
    Signed-off-by: Martin Kaiser <martin@kaiser.cx>
    Link: https://lore.kernel.org/r/20220226181457.1138035-4-martin@kaiser.cx
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/r8188eu/core/rtw_recv.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
    index 51a13262a226..d120d61454a3 100644
    --- a/drivers/staging/r8188eu/core/rtw_recv.c
    +++ b/drivers/staging/r8188eu/core/rtw_recv.c
    @@ -1853,8 +1853,7 @@ static int recv_func(struct adapter *padapter, struct recv_frame *rframe)
    struct recv_frame *pending_frame;
    int cnt = 0;

    - pending_frame = rtw_alloc_recvframe(&padapter->recvpriv.uc_swdec_pending_queue);
    - while (pending_frame) {
    + while ((pending_frame = rtw_alloc_recvframe(&padapter->recvpriv.uc_swdec_pending_queue))) {
    cnt++;
    recv_func_posthandle(padapter, pending_frame);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 11:13    [W:4.090 / U:0.868 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site