lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0362/1126] ASoC: codecs: wcd938x: fix kcontrol max values
    Date
    From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

    [ Upstream commit b0217519236924f77a8382b4004e43ef8fd0dcbb ]

    set "HPH Type" Kcontrol max value of WCD_MBHC_HPH_STEREO instead of UINT_MAX.
    set "HPHL/R Impedance" Kcontrols max value to INT_MAX instead of UINT_MAX as
    max field is integer type.

    Without this patch amixer for these controls will show -1 as max value to userspace.

    Fixes: bcee7ed09b8e ("ASoC: codecs: wcd938x: add Multi Button Headset Control support")
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Link: https://lore.kernel.org/r/20220222183212.11580-8-srinivas.kandagatla@linaro.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/wcd938x.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
    index 33d5403d4e62..9ae65cbabb1a 100644
    --- a/sound/soc/codecs/wcd938x.c
    +++ b/sound/soc/codecs/wcd938x.c
    @@ -3575,14 +3575,14 @@ static int wcd938x_hph_impedance_get(struct snd_kcontrol *kcontrol,
    }

    static const struct snd_kcontrol_new hph_type_detect_controls[] = {
    - SOC_SINGLE_EXT("HPH Type", 0, 0, UINT_MAX, 0,
    + SOC_SINGLE_EXT("HPH Type", 0, 0, WCD_MBHC_HPH_STEREO, 0,
    wcd938x_get_hph_type, NULL),
    };

    static const struct snd_kcontrol_new impedance_detect_controls[] = {
    - SOC_SINGLE_EXT("HPHL Impedance", 0, 0, UINT_MAX, 0,
    + SOC_SINGLE_EXT("HPHL Impedance", 0, 0, INT_MAX, 0,
    wcd938x_hph_impedance_get, NULL),
    - SOC_SINGLE_EXT("HPHR Impedance", 0, 1, UINT_MAX, 0,
    + SOC_SINGLE_EXT("HPHR Impedance", 0, 1, INT_MAX, 0,
    wcd938x_hph_impedance_get, NULL),
    };

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 10:52    [W:2.440 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site