lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0381/1126] ASoC: mxs-saif: Handle errors for clk_enable
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 2ecf362d220317debf5da376e0390e9f7a3f7b29 ]

    As the potential failure of the clk_enable(),
    it should be better to check it, like mxs_saif_trigger().

    Fixes: d0ba4c014934 ("ASoC: mxs-saif: set a base clock rate for EXTMASTER mode work")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Link: https://lore.kernel.org/r/20220301081717.3727190-1-jiasheng@iscas.ac.cn
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/mxs/mxs-saif.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
    index 6a2d24d48964..879c1221a809 100644
    --- a/sound/soc/mxs/mxs-saif.c
    +++ b/sound/soc/mxs/mxs-saif.c
    @@ -455,7 +455,10 @@ static int mxs_saif_hw_params(struct snd_pcm_substream *substream,
    * basic clock which should be fast enough for the internal
    * logic.
    */
    - clk_enable(saif->clk);
    + ret = clk_enable(saif->clk);
    + if (ret)
    + return ret;
    +
    ret = clk_set_rate(saif->clk, 24000000);
    clk_disable(saif->clk);
    if (ret)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 10:39    [W:2.893 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site