lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0690/1017] mailbox: imx: fix crash in resume on i.mx8ulp
    Date
    From: Robin Gong <yibin.gong@nxp.com>

    [ Upstream commit 8219efd08a0aa1d7944bdb66d84ba57549258968 ]

    check 'priv->clk' before 'imx_mu_read()' otherwise crash happens on
    i.mx8ulp, since clock not enabled.

    Fixes: 4f0b776ef5831 ("mailbox: imx-mailbox: support i.MX8ULP MU")
    Reviewed-by: Jacky Bai <ping.bai@nxp.com>
    Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    Signed-off-by: Peng Fan <peng.fan@nxp.com>
    Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mailbox/imx-mailbox.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
    index 544de2db6453..3c9c87b9c872 100644
    --- a/drivers/mailbox/imx-mailbox.c
    +++ b/drivers/mailbox/imx-mailbox.c
    @@ -718,7 +718,7 @@ static int __maybe_unused imx_mu_resume_noirq(struct device *dev)
    * send failed, may lead to system freeze. This issue
    * is observed by testing freeze mode suspend.
    */
    - if (!imx_mu_read(priv, priv->dcfg->xCR[0]) && !priv->clk) {
    + if (!priv->clk && !imx_mu_read(priv, priv->dcfg->xCR[0])) {
    for (i = 0; i < IMX_MU_xCR_MAX; i++)
    imx_mu_write(priv, priv->xcr[i], priv->dcfg->xCR[i]);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:20    [W:4.836 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site