lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0254/1126] KEYS: trusted: Fix trusted key backends when building as module
    Date
    From: Andreas Rammhold <andreas@rammhold.de>

    [ Upstream commit 969a26446bcd142faedfe8c6f41cd7668596c1fa ]

    Before this commit the kernel could end up with no trusted key sources
    even though both of the currently supported backends (TPM and TEE) were
    compiled as modules. This manifested in the trusted key type not being
    registered at all.

    When checking if a CONFIG_… preprocessor variable is defined we only
    test for the builtin (=y) case and not the module (=m) case. By using
    the IS_REACHABLE() macro we do test for both cases.

    Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
    Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
    Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
    Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
    Signed-off-by: Andreas Rammhold <andreas@rammhold.de>
    Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
    Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
    Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    security/keys/trusted-keys/trusted_core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/security/keys/trusted-keys/trusted_core.c b/security/keys/trusted-keys/trusted_core.c
    index d5c891d8d353..5b35f1b87644 100644
    --- a/security/keys/trusted-keys/trusted_core.c
    +++ b/security/keys/trusted-keys/trusted_core.c
    @@ -27,10 +27,10 @@ module_param_named(source, trusted_key_source, charp, 0);
    MODULE_PARM_DESC(source, "Select trusted keys source (tpm or tee)");

    static const struct trusted_key_source trusted_key_sources[] = {
    -#if defined(CONFIG_TCG_TPM)
    +#if IS_REACHABLE(CONFIG_TCG_TPM)
    { "tpm", &trusted_key_tpm_ops },
    #endif
    -#if defined(CONFIG_TEE)
    +#if IS_REACHABLE(CONFIG_TEE)
    { "tee", &trusted_key_tee_ops },
    #endif
    };
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:19    [W:4.022 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site