Messages in this thread | | | From | Nick Desaulniers <> | Date | Tue, 5 Apr 2022 09:21:42 -0700 | Subject | Re: [PATCH v2 05/10] modpost: remove redundant initializes for static variables |
| |
On Tue, Apr 5, 2022 at 4:34 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > These are initialized with zeros without explicit initializes.
s/initializes/initializers/
Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Changes in v2: > - New > > scripts/mod/modpost.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index f9e54247ae1d..2a202764ff48 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -23,15 +23,15 @@ > #include "../../include/linux/license.h" > > /* Are we using CONFIG_MODVERSIONS? */ > -static int modversions = 0; > +static int modversions; > /* Is CONFIG_MODULE_SRCVERSION_ALL set? */ > -static int all_versions = 0; > +static int all_versions; > /* If we are modposting external module set to 1 */ > -static int external_module = 0; > +static int external_module; > /* Only warn about unresolved symbols */ > -static int warn_unresolved = 0; > +static int warn_unresolved; > /* How a symbol is exported */ > -static int sec_mismatch_count = 0; > +static int sec_mismatch_count; > static int sec_mismatch_warn_only = true; > /* ignore missing files */ > static int ignore_missing_files; > -- > 2.32.0 >
-- Thanks, ~Nick Desaulniers
| |