lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 549/599] can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path
    Date
    From: Hangyu Hua <hbh25y@gmail.com>

    commit 04c9b00ba83594a29813d6b1fb8fdc93a3915174 upstream.

    There is no need to call dev_kfree_skb() when usb_submit_urb() fails
    because can_put_echo_skb() deletes original skb and
    can_free_echo_skb() deletes the cloned skb.

    Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
    Link: https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/can/usb/mcba_usb.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/net/can/usb/mcba_usb.c
    +++ b/drivers/net/can/usb/mcba_usb.c
    @@ -368,7 +368,6 @@ static netdev_tx_t mcba_usb_start_xmit(s
    xmit_failed:
    can_free_echo_skb(priv->netdev, ctx->ndx);
    mcba_usb_free_ctx(ctx);
    - dev_kfree_skb(skb);
    stats->tx_dropped++;

    return NETDEV_TX_OK;

    \
     
     \ /
      Last update: 2022-04-06 07:16    [W:4.019 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site