Messages in this thread | | | Date | Tue, 5 Apr 2022 18:23:54 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 0/2] thermal: Add support of multiple sensors |
| |
Hi Angelo,
On 05/04/2022 14:14, AngeloGioacchino Del Regno wrote:
[ ... ]
> Hello Eduardo, Kevin, > > I would like to add that this series is not only benefitting MediaTek > platforms, and not only Chromebooks. On some Qualcomm SoCs (from > SDM845 onwards, if I'm not wrong!), downstream, there is some "qti > virtual sensor" driver, which is addressing this kind of situation: > on these platforms, averaging, min and max (and some interpolation > too, but that's another story, I guess) is happening and that's used > as some advanced way to ensure that both performance stays high and > that the device is safe to operate. On these platforms, this is done > by evaluating CPU, GPU, Hexagon DSPs, modem, wifi and (modem,wifi)PA > IPs and deciding on a thermal throttling strategy. > > You understand that, while this is not "excessively" important for a > Chromebook, which is a laptop, it may become even a safety concern > in devices of other form factor, like smartphones, where there is a > very strict thermal headroom (hence requiring a fine grained thermal > management). > > Even though, on MediaTek, I guess that the primary usecase is > Chromebooks and this kind of mechanism is required primarily for the > LVTS sensors that are used for SVS calculations (read: better power > efficiency), the Linux community is huge - and, with this kept in > mind, there will probably be someone that will like to upstream their > MTK smartphone for a reason or another (I think! This happened with > Qualcomm so I guess that it's going to happen with "any other > thing")... and that adds up to this problem being a safety concern to > fix. > > Of course, I agree with you, Eduardo, about the needed cleanup but, > for all of the aforementioned reasons - mine and Kevin's, like him, I > would also beg, plead and grovel that you consider merging this > series as a first phase, and accept the cleanup and use-case > expansion as a second phase.
I'll take care of the cleanups and then respin Alex's series on top of those.
Thanks
-- Daniel
> P.S.: I'm adding Marijn and Konrad to the loop, as people interested > to the Qualcomm side of things, and mainly upstreaming smartphones. > > Kind regards, Angelo
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |