lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0385/1126] media: i2c: Fix pixel array positions in ov8865
    Date
    From: Daniel Scally <djrscally@gmail.com>

    [ Upstream commit 3d1e4228c9dd5c945a5cb621749f358766ee5777 ]

    The ov8865's datasheet gives the pixel array as 3296x2528, and the
    active portion as the centre 3264x2448. This makes for a top offset
    of 40 and a left offset of 16, not 32 and 80.

    Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")

    Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
    Signed-off-by: Daniel Scally <djrscally@gmail.com>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/ov8865.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
    index d9d016cfa9ac..e0dd0f4849a7 100644
    --- a/drivers/media/i2c/ov8865.c
    +++ b/drivers/media/i2c/ov8865.c
    @@ -457,8 +457,8 @@

    #define OV8865_NATIVE_WIDTH 3296
    #define OV8865_NATIVE_HEIGHT 2528
    -#define OV8865_ACTIVE_START_TOP 32
    -#define OV8865_ACTIVE_START_LEFT 80
    +#define OV8865_ACTIVE_START_LEFT 16
    +#define OV8865_ACTIVE_START_TOP 40
    #define OV8865_ACTIVE_WIDTH 3264
    #define OV8865_ACTIVE_HEIGHT 2448

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 10:24    [W:4.036 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site