Messages in this thread | | | Date | Tue, 5 Apr 2022 18:14:11 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net] net: phy: marvell-88x2222: set proper phydev->port |
| |
On Tue, Apr 05, 2022 at 06:03:05PM +0300, Ivan Bornyakov wrote: > phydev->port was not set and always reported as PORT_TP. > Set phydev->port according to inserted SFP module.
This is definitely something for Russell to review.
But i'm wondering if this is the correct place to do this? What about at803x and marvell10g? It seems like this should be done once in the core somewhere, not in each driver.
Andrew
| |