lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 307/599] drm/msm/dpu: fix dp audio condition
    Date
    From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

    [ Upstream commit 1e0505a5a7a2fea243f8e6d7e13fcde65f9e41bc ]

    DP audio enablement code which is comparing intf_type,
    DRM_MODE_ENCODER_TMDS (= 2) with DRM_MODE_CONNECTOR_DisplayPort (= 10).
    Which would never succeed. Fix it to check for DRM_MODE_ENCODER_TMDS.

    Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM")
    Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Reviewed-by: Stephen Boyd <swboyd@chromium.org>
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Link: https://lore.kernel.org/r/20220217035358.465904-2-dmitry.baryshkov@linaro.org
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
    index f7f5c258b553..a0274fcfe9c9 100644
    --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
    +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
    @@ -1113,7 +1113,7 @@ static void _dpu_encoder_virt_enable_helper(struct drm_encoder *drm_enc)
    }


    - if (dpu_enc->disp_info.intf_type == DRM_MODE_CONNECTOR_DisplayPort &&
    + if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_TMDS &&
    dpu_enc->cur_master->hw_mdptop &&
    dpu_enc->cur_master->hw_mdptop->ops.intf_audio_select)
    dpu_enc->cur_master->hw_mdptop->ops.intf_audio_select(
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-06 02:18    [W:2.106 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site