lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [ovs-dev] [PATCH net] net: openvswitch: don't send internal clone attribute to the userspace.
Date
Ilya Maximets <i.maximets@ovn.org> writes:

> 'OVS_CLONE_ATTR_EXEC' is an internal attribute that is used for
> performance optimization inside the kernel. It's added by the kernel
> while parsing user-provided actions and should not be sent during the
> flow dump as it's not part of the uAPI.
>
> The issue doesn't cause any significant problems to the ovs-vswitchd
> process, because reported actions are not really used in the
> application lifecycle and only supposed to be shown to a human via
> ovs-dpctl flow dump. However, the action list is still incorrect
> and causes the following error if the user wants to look at the
> datapath flows:
>
> # ovs-dpctl add-dp system@ovs-system
> # ovs-dpctl add-flow "<flow match>" "clone(ct(commit),0)"
> # ovs-dpctl dump-flows
> <flow match>, packets:0, bytes:0, used:never,
> actions:clone(bad length 4, expected -1 for: action0(01 00 00 00),
> ct(commit),0)
>
> With the fix:
>
> # ovs-dpctl dump-flows
> <flow match>, packets:0, bytes:0, used:never,
> actions:clone(ct(commit),0)
>
> Additionally fixed an incorrect attribute name in the comment.
>
> Fixes: b233504033db ("openvswitch: kernel datapath clone action")
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

\
 
 \ /
  Last update: 2022-04-06 01:36    [W:0.033 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site