lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 610/913] clk: imx: off by one in imx_lpcg_parse_clks_from_dt()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 135efc3a76d127691afaf1864e4ab627bf09d53d ]

    The > needs to be >= to prevent an off by one access.

    Fixes: d5f1e6a2bb61 ("clk: imx: imx8qxp-lpcg: add parsing clocks from device tree")
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
    Link: https://lore.kernel.org/r/20220228075014.GD13685@kili
    Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
    index b23758083ce5..5e31a6a24b3a 100644
    --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
    +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
    @@ -248,7 +248,7 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,

    for (i = 0; i < count; i++) {
    idx = bit_offset[i] / 4;
    - if (idx > IMX_LPCG_MAX_CLKS) {
    + if (idx >= IMX_LPCG_MAX_CLKS) {
    dev_warn(&pdev->dev, "invalid bit offset of clock %d\n",
    i);
    ret = -EINVAL;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-06 01:29    [W:2.983 / U:1.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site