lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0202/1126] crypto: qat - fix a signedness bug in get_service_enabled()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 844318dfd31f7c99f6cebbdba5d6f8392c4c115c ]

    The "ret" variable needs to be signed or there is an error message which
    will not be printed correctly.

    Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
    index 6d10edc40aca..68d39c833332 100644
    --- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
    +++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
    @@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = {
    static int get_service_enabled(struct adf_accel_dev *accel_dev)
    {
    char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0};
    - u32 ret;
    + int ret;

    ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC,
    ADF_SERVICES_ENABLED, services);
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 10:08    [W:2.797 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site