lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 447/599] lib/test: use after free in register_test_dev_kmod()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit dc0ce6cc4b133f5f2beb8b47dacae13a7d283c2c ]

    The "test_dev" pointer is freed but then returned to the caller.

    Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    lib/test_kmod.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/lib/test_kmod.c b/lib/test_kmod.c
    index eab52770070d..c637f6b5053a 100644
    --- a/lib/test_kmod.c
    +++ b/lib/test_kmod.c
    @@ -1155,6 +1155,7 @@ static struct kmod_test_device *register_test_dev_kmod(void)
    if (ret) {
    pr_err("could not register misc device: %d\n", ret);
    free_test_dev_kmod(test_dev);
    + test_dev = NULL;
    goto out;
    }

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-06 01:19    [W:4.036 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site