Messages in this thread | | | Date | Tue, 5 Apr 2022 10:44:36 +0530 | Subject | Re: [PATCH v5 2/3] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset | From | Srinivasa Rao Mandadapu <> |
| |
On 3/22/2022 2:00 AM, Stephen Boyd wrote: Thanks for your time Stephen!!! > Quoting Srinivasa Rao Mandadapu (2022-03-21 04:59:18) >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> index 688fa95..4a7b18a 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> @@ -462,7 +462,28 @@ >> drive-strength = <10>; >> }; >> >> +&sec_mi2s_data0 { >> + drive-strength = <6>; >> + bias-disable; >> +}; >> + >> +&sec_mi2s_sclk { >> + drive-strength = <6>; >> + bias-disable; >> +}; >> + >> +&sec_mi2s_ws { >> + drive-strength = <6>; >> +}; >> + >> &tlmm { >> + amp_en: amp-en { >> + pins = "gpio63"; >> + function = "gpio"; > I'm pretty sure 'function = "gpio"' isn't needed. When a gpio is > requested with gpio functions it gets muxed to gpio function > automatically. See commit 1de7ddb3a15c ("pinctrl: msm: Mux out gpio > function with gpio_request()"). Okay. Will remove it. > >> + bias-pull-down; >> + drive-strength = <2>; >> + }; >> + >> bt_en: bt-en { >> pins = "gpio85"; >> function = "gpio";
| |