lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 128/599] regulator: qcom_smd: fix for_each_child.cocci warnings
    Date
    From: kernel test robot <lkp@intel.com>

    [ Upstream commit 6390d42c21efff0b4c10956a38e341f4e84ecd3d ]

    drivers/regulator/qcom_smd-regulator.c:1318:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1321.

    Semantic patch information:
    False positives can be due to function calls within the for_each
    loop that may encapsulate an of_node_put.

    Generated by: scripts/coccinelle/iterators/for_each_child.cocci

    Fixes: 14e2976fbabd ("regulator: qcom_smd: Align probe function with rpmh-regulator")
    CC: Konrad Dybcio <konrad.dybcio@somainline.org>
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
    Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2201151210170.3051@hadrien
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/qcom_smd-regulator.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
    index 03e146e98abd..8d784a2a09d8 100644
    --- a/drivers/regulator/qcom_smd-regulator.c
    +++ b/drivers/regulator/qcom_smd-regulator.c
    @@ -1185,8 +1185,10 @@ static int rpm_reg_probe(struct platform_device *pdev)

    for_each_available_child_of_node(dev->of_node, node) {
    vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL);
    - if (!vreg)
    + if (!vreg) {
    + of_node_put(node);
    return -ENOMEM;
    + }

    ret = rpm_regulator_init_vreg(vreg, dev, node, rpm, vreg_data);

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-06 01:05    [W:2.342 / U:0.964 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site