lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 565/913] selftests/bpf/test_lirc_mode2.sh: Exit with proper code
    Date
    From: Hangbin Liu <liuhangbin@gmail.com>

    [ Upstream commit ec80906b0fbd7be11e3e960813b977b1ffe5f8fe ]

    When test_lirc_mode2_user exec failed, the test report failed but still
    exit with 0. Fix it by exiting with an error code.

    Another issue is for the LIRCDEV checking. With bash -n, we need to quote
    the variable, or it will always be true. So if test_lirc_mode2_user was
    not run, just exit with skip code.

    Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program")
    Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Link: https://lore.kernel.org/bpf/20220321024149.157861-1-liuhangbin@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/test_lirc_mode2.sh | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh
    index ec4e15948e40..5252b91f48a1 100755
    --- a/tools/testing/selftests/bpf/test_lirc_mode2.sh
    +++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh
    @@ -3,6 +3,7 @@

    # Kselftest framework requirement - SKIP code is 4.
    ksft_skip=4
    +ret=$ksft_skip

    msg="skip all tests:"
    if [ $UID != 0 ]; then
    @@ -25,7 +26,7 @@ do
    fi
    done

    -if [ -n $LIRCDEV ];
    +if [ -n "$LIRCDEV" ];
    then
    TYPE=lirc_mode2
    ./test_lirc_mode2_user $LIRCDEV $INPUTDEV
    @@ -36,3 +37,5 @@ then
    echo -e ${GREEN}"PASS: $TYPE"${NC}
    fi
    fi
    +
    +exit $ret
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-06 00:11    [W:3.663 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site