lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0213/1126] spi: tegra114: Add missing IRQ check in tegra_spi_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 4f92724d4b92c024e721063f520d66e11ca4b54b ]

    This func misses checking for platform_get_irq()'s call and may passes the
    negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
    causing it to fail with -EINVAL, overriding an original error code.
    Stop calling request_threaded_irq() with invalid IRQ #s.

    Fixes: f333a331adfa ("spi/tegra114: add spi driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220128165238.25615-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-tegra114.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
    index e9de1d958bbd..8f345247a8c3 100644
    --- a/drivers/spi/spi-tegra114.c
    +++ b/drivers/spi/spi-tegra114.c
    @@ -1352,6 +1352,10 @@ static int tegra_spi_probe(struct platform_device *pdev)
    tspi->phys = r->start;

    spi_irq = platform_get_irq(pdev, 0);
    + if (spi_irq < 0) {
    + ret = spi_irq;
    + goto exit_free_master;
    + }
    tspi->irq = spi_irq;

    tspi->clk = devm_clk_get(&pdev->dev, "spi");
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 10:04    [W:4.021 / U:1.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site