lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 429/599] firmware: google: Properly state IOMEM dependency
    Date
    From: David Gow <davidgow@google.com>

    [ Upstream commit 37fd83916da2e4cae03d350015c82a67b1b334c4 ]

    The Google Coreboot implementation requires IOMEM functions
    (memmremap, memunmap, devm_memremap), but does not specify this is its
    Kconfig. This results in build errors when HAS_IOMEM is not set, such as
    on some UML configurations:

    /usr/bin/ld: drivers/firmware/google/coreboot_table.o: in function `coreboot_table_probe':
    coreboot_table.c:(.text+0x311): undefined reference to `memremap'
    /usr/bin/ld: coreboot_table.c:(.text+0x34e): undefined reference to `memunmap'
    /usr/bin/ld: drivers/firmware/google/memconsole-coreboot.o: in function `memconsole_probe':
    memconsole-coreboot.c:(.text+0x12d): undefined reference to `memremap'
    /usr/bin/ld: memconsole-coreboot.c:(.text+0x17e): undefined reference to `devm_memremap'
    /usr/bin/ld: memconsole-coreboot.c:(.text+0x191): undefined reference to `memunmap'
    /usr/bin/ld: drivers/firmware/google/vpd.o: in function `vpd_section_destroy.isra.0':
    vpd.c:(.text+0x300): undefined reference to `memunmap'
    /usr/bin/ld: drivers/firmware/google/vpd.o: in function `vpd_section_init':
    vpd.c:(.text+0x382): undefined reference to `memremap'
    /usr/bin/ld: vpd.c:(.text+0x459): undefined reference to `memunmap'
    /usr/bin/ld: drivers/firmware/google/vpd.o: in function `vpd_probe':
    vpd.c:(.text+0x59d): undefined reference to `memremap'
    /usr/bin/ld: vpd.c:(.text+0x5d3): undefined reference to `memunmap'
    collect2: error: ld returned 1 exit status

    Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
    Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
    Acked-By: Julius Werner <jwerner@chromium.org>
    Signed-off-by: David Gow <davidgow@google.com>
    Link: https://lore.kernel.org/r/20220225041502.1901806-1-davidgow@google.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/google/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
    index 931544c9f63d..983e07dc022e 100644
    --- a/drivers/firmware/google/Kconfig
    +++ b/drivers/firmware/google/Kconfig
    @@ -21,7 +21,7 @@ config GOOGLE_SMI

    config GOOGLE_COREBOOT_TABLE
    tristate "Coreboot Table Access"
    - depends on ACPI || OF
    + depends on HAS_IOMEM && (ACPI || OF)
    help
    This option enables the coreboot_table module, which provides other
    firmware modules access to the coreboot table. The coreboot table
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 22:58    [W:4.049 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site