lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 551/599] can: mcp251xfd: mcp251xfd_register_get_dev_id(): fix return of error value
    Date
    From: Tom Rix <trix@redhat.com>

    commit fa7b514d2b2894e052b8e94c7a29feb98e90093f upstream.

    Clang static analysis reports this issue:

    | mcp251xfd-core.c:1813:7: warning: The left operand
    | of '&' is a garbage value
    | FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id),
    | ^ ~~~~~~

    dev_id is set in a successful call to mcp251xfd_register_get_dev_id().
    Though the status of calls made by mcp251xfd_register_get_dev_id() are
    checked and handled, their status' are not returned. So return err.

    Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
    Link: https://lore.kernel.org/all/20220319153128.2164120-1-trix@redhat.com
    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
    +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
    @@ -2578,7 +2578,7 @@ mcp251xfd_register_get_dev_id(const stru
    out_kfree_buf_rx:
    kfree(buf_rx);

    - return 0;
    + return err;
    }

    #define MCP251XFD_QUIRK_ACTIVE(quirk) \

    \
     
     \ /
      Last update: 2022-04-05 22:42    [W:2.244 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site