lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 296/913] soc: qcom: rpmpd: Check for null return of devm_kcalloc
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 5a811126d38f9767a20cc271b34db7c8efc5a46c ]

    Because of the possible failure of the allocation, data->domains might
    be NULL pointer and will cause the dereference of the NULL pointer
    later.
    Therefore, it might be better to check it and directly return -ENOMEM
    without releasing data manually if fails, because the comment of the
    devm_kmalloc() says "Memory allocated with this function is
    automatically freed on driver detach.".

    Fixes: bbe3a66c3f5a ("soc: qcom: rpmpd: Add a Power domain driver to model corners")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20211231094419.1941054-1-jiasheng@iscas.ac.cn
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/rpmpd.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
    index dbf494e92574..9f07274b0d28 100644
    --- a/drivers/soc/qcom/rpmpd.c
    +++ b/drivers/soc/qcom/rpmpd.c
    @@ -546,6 +546,9 @@ static int rpmpd_probe(struct platform_device *pdev)

    data->domains = devm_kcalloc(&pdev->dev, num, sizeof(*data->domains),
    GFP_KERNEL);
    + if (!data->domains)
    + return -ENOMEM;
    +
    data->num_domains = num;

    for (i = 0; i < num; i++) {
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 22:40    [W:4.182 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site