lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 088/599] ACPI: properties: Consistently return -ENOENT if there are no more references
    Date
    From: Sakari Ailus <sakari.ailus@linux.intel.com>

    commit babc92da5928f81af951663fc436997352e02d3a upstream.

    __acpi_node_get_property_reference() is documented to return -ENOENT if
    the caller requests a property reference at an index that does not exist,
    not -EINVAL which it actually does.

    Fix this by returning -ENOENT consistenly, independently of whether the
    property value is a plain reference or a package.

    Fixes: c343bc2ce2c6 ("ACPI: properties: Align return codes of __acpi_node_get_property_reference()")
    Cc: 4.14+ <stable@vger.kernel.org> # 4.14+
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/acpi/property.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/acpi/property.c
    +++ b/drivers/acpi/property.c
    @@ -685,7 +685,7 @@ int __acpi_node_get_property_reference(c
    */
    if (obj->type == ACPI_TYPE_LOCAL_REFERENCE) {
    if (index)
    - return -EINVAL;
    + return -ENOENT;

    ret = acpi_bus_get_device(obj->reference.handle, &device);
    if (ret)

    \
     
     \ /
      Last update: 2022-04-05 22:31    [W:2.106 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site