lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 469/913] drm/msm/dp: populate connector of struct dp_panel
    Date
    From: Kuogee Hsieh <quic_khsieh@quicinc.com>

    [ Upstream commit 5e602f5156910c7b19661699896cb6e3fb94fab9 ]

    DP CTS test case 4.2.2.6 has valid edid with bad checksum on purpose
    and expect DP source return correct checksum. During drm edid read,
    correct edid checksum is calculated and stored at
    connector::real_edid_checksum.

    The problem is struct dp_panel::connector never be assigned, instead the
    connector is stored in struct msm_dp::connector. When we run compliance
    testing test case 4.2.2.6 dp_panel_handle_sink_request() won't have a valid
    edid set in struct dp_panel::edid so we'll try to use the connectors
    real_edid_checksum and hit a NULL pointer dereference error because the
    connector pointer is never assigned.

    Changes in V2:
    -- populate panel connector at msm_dp_modeset_init() instead of at dp_panel_read_sink_caps()

    Changes in V3:
    -- remove unhelpful kernel crash trace commit text
    -- remove renaming dp_display parameter to dp

    Changes in V4:
    -- add more details to commit text

    Changes in v10:
    -- group into one series

    Changes in v11:
    -- drop drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read

    Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted edid checksum read")
    Signee-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>

    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Reviewed-by: Stephen Boyd <swboyd@chromium.org>
    Link: https://lore.kernel.org/r/1642531648-8448-3-git-send-email-quic_khsieh@quicinc.com
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/dp/dp_display.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
    index a0392e4d8134..d5198b435638 100644
    --- a/drivers/gpu/drm/msm/dp/dp_display.c
    +++ b/drivers/gpu/drm/msm/dp/dp_display.c
    @@ -1442,6 +1442,7 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,
    struct drm_encoder *encoder)
    {
    struct msm_drm_private *priv;
    + struct dp_display_private *dp_priv;
    int ret;

    if (WARN_ON(!encoder) || WARN_ON(!dp_display) || WARN_ON(!dev))
    @@ -1450,6 +1451,8 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,
    priv = dev->dev_private;
    dp_display->drm_dev = dev;

    + dp_priv = container_of(dp_display, struct dp_display_private, dp_display);
    +
    ret = dp_display_request_irq(dp_display);
    if (ret) {
    DRM_ERROR("request_irq failed, ret=%d\n", ret);
    @@ -1467,6 +1470,8 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,
    return ret;
    }

    + dp_priv->panel->connector = dp_display->connector;
    +
    priv->connectors[priv->num_connectors++] = dp_display->connector;
    return 0;
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 22:20    [W:2.271 / U:3.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site