lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 273/913] media: imx: imx8mq-mipi-csi2: remove wrong irq config write operation
    Date
    From: Martin Kepplinger <martin.kepplinger@puri.sm>

    [ Upstream commit 59c2b6d51803ad6b7af28f2a60a843b24374e692 ]

    The place where this register writel() that masks one interrupt is placed
    does not guarantee that the device is powered so that's not allowed.
    Moreover imx8mq_mipi_csi_start_stream() masks the interrupt anyway so the
    write is not even needed. Remove it as this is a mistake that slipped in
    with the driver.

    Fixes: f33fd8d77dd0 ("media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller")
    Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/imx/imx8mq-mipi-csi2.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
    index a6f562009b9a..e9e771717120 100644
    --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c
    +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c
    @@ -398,9 +398,6 @@ static int imx8mq_mipi_csi_s_stream(struct v4l2_subdev *sd, int enable)
    struct csi_state *state = mipi_sd_to_csi2_state(sd);
    int ret = 0;

    - imx8mq_mipi_csi_write(state, CSI2RX_IRQ_MASK,
    - CSI2RX_IRQ_MASK_ULPS_STATUS_CHANGE);
    -
    if (enable) {
    ret = pm_runtime_resume_and_get(state->dev);
    if (ret < 0)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 22:00    [W:4.023 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site