lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 264/913] pinctrl: samsung: Remove EINT handler for Exynos850 ALIVE and CMGP gpios
    Date
    From: Sam Protsenko <semen.protsenko@linaro.org>

    [ Upstream commit 96f79935015cf3d7ca6fabf63cd13b8af45a7713 ]

    GPIO_ALIVE and GPIO_CMGP blocks in Exynos850 SoC don't have EINT
    capabilities (like EINT_SVC register), and there are no corresponding
    interrupts wired to GIC. Instead those blocks have wake-up interrupts
    for each pin. The ".eint_gpio_init" callbacks were specified by mistake
    for these blocks, when porting pinctrl code from downstream kernel. That
    leads to error messages like this:

    samsung-pinctrl 11850000.pinctrl: irq number not available

    Remove ".eint_gpio_init" for pinctrl_alive and pinctrl_gpmc to fix this
    error. This change doesn't affect proper interrupt handling for related
    pins, as all those pins are handled in ".eint_wkup_init".

    Fixes: cdd3d945dcec ("pinctrl: samsung: Add Exynos850 SoC specific data")
    Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
    Link: https://lore.kernel.org/r/20220114203757.4860-1-semen.protsenko@linaro.org
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
    index fe5f6046fbd5..cc66f852ef7b 100644
    --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
    +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
    @@ -504,13 +504,11 @@ static const struct samsung_pin_ctrl exynos850_pin_ctrl[] __initconst = {
    /* pin-controller instance 0 ALIVE data */
    .pin_banks = exynos850_pin_banks0,
    .nr_banks = ARRAY_SIZE(exynos850_pin_banks0),
    - .eint_gpio_init = exynos_eint_gpio_init,
    .eint_wkup_init = exynos_eint_wkup_init,
    }, {
    /* pin-controller instance 1 CMGP data */
    .pin_banks = exynos850_pin_banks1,
    .nr_banks = ARRAY_SIZE(exynos850_pin_banks1),
    - .eint_gpio_init = exynos_eint_gpio_init,
    .eint_wkup_init = exynos_eint_wkup_init,
    }, {
    /* pin-controller instance 2 AUD data */
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 21:59    [W:2.147 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site