lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0771/1017] irqchip/nvic: Release nvic_base upon failure
    Date
    From: Souptick Joarder (HPE) <jrdr.linux@gmail.com>

    [ Upstream commit e414c25e3399b2b3d7337dc47abccab5c71b7c8f ]

    smatch warning was reported as below ->

    smatch warnings:
    drivers/irqchip/irq-nvic.c:131 nvic_of_init()
    warn: 'nvic_base' not released on lines: 97.

    Release nvic_base upon failure.

    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/irqchip/irq-nvic.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
    index ba4759b3e269..94230306e0ee 100644
    --- a/drivers/irqchip/irq-nvic.c
    +++ b/drivers/irqchip/irq-nvic.c
    @@ -107,6 +107,7 @@ static int __init nvic_of_init(struct device_node *node,

    if (!nvic_irq_domain) {
    pr_warn("Failed to allocate irq domain\n");
    + iounmap(nvic_base);
    return -ENOMEM;
    }

    @@ -116,6 +117,7 @@ static int __init nvic_of_init(struct device_node *node,
    if (ret) {
    pr_warn("Failed to allocate irq chips\n");
    irq_domain_remove(nvic_irq_domain);
    + iounmap(nvic_base);
    return ret;
    }

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 15:44    [W:4.049 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site