lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0703/1017] pinctrl/rockchip: Add missing of_node_put() in rockchip_pinctrl_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 89388f8730699c259f8090ec435fb43569efe4ac ]

    The device_node pointer is returned by of_parse_phandle() with refcount
    incremented. We should use of_node_put() on it when done.

    Fixes: 1e747e59cc4d ("pinctrl: rockchip: base regmap supplied by a syscon")
    Fixes: 14dee8677e19 ("pinctrl: rockchip: let pmu registers be supplied by a syscon")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220307120234.28657-1-linmq006@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/pinctrl-rockchip.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
    index dc52da94af0b..923ff21a44c0 100644
    --- a/drivers/pinctrl/pinctrl-rockchip.c
    +++ b/drivers/pinctrl/pinctrl-rockchip.c
    @@ -2702,6 +2702,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
    node = of_parse_phandle(np, "rockchip,grf", 0);
    if (node) {
    info->regmap_base = syscon_node_to_regmap(node);
    + of_node_put(node);
    if (IS_ERR(info->regmap_base))
    return PTR_ERR(info->regmap_base);
    } else {
    @@ -2738,6 +2739,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
    node = of_parse_phandle(np, "rockchip,pmu", 0);
    if (node) {
    info->regmap_pmu = syscon_node_to_regmap(node);
    + of_node_put(node);
    if (IS_ERR(info->regmap_pmu))
    return PTR_ERR(info->regmap_pmu);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 15:39    [W:2.506 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site