lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 0027/1126] coresight: syscfg: Fix memleak on registration failure in cscfg_create_device
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit cfa5dbcdd7aece76f3415284569f2f384aff0253 upstream.

    device_register() calls device_initialize(),
    according to doc of device_initialize:

    Use put_device() to give up your reference instead of freeing
    * @dev directly once you have called this function.

    To prevent potential memleak, use put_device() for error handling.

    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration")
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/20220124124121.8888-1-linmq006@gmail.com
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/hwtracing/coresight/coresight-syscfg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hwtracing/coresight/coresight-syscfg.c
    +++ b/drivers/hwtracing/coresight/coresight-syscfg.c
    @@ -1049,7 +1049,7 @@ static int cscfg_create_device(void)

    err = device_register(dev);
    if (err)
    - cscfg_dev_release(dev);
    + put_device(dev);

    create_dev_exit_unlock:
    mutex_unlock(&cscfg_mutex);

    \
     
     \ /
      Last update: 2022-04-05 09:41    [W:4.095 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site