lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0511/1017] iwlwifi: yoyo: remove DBGI_SRAM address reset writing
    Date
    From: Rotem Saado <rotem.saado@intel.com>

    [ Upstream commit ce014c9861544bb4e789323d0d8956a5ad262e25 ]

    Due to preg protection we cannot write to this register
    while FW is running (when FW in Halt it is ok).
    since we have some cases that we need to dump this
    region while FW is running remove this writing from DRV.
    FW will do this writing.

    Signed-off-by: Rotem Saado <rotem.saado@intel.com>
    Fixes: 89639e06d0f3 ("iwlwifi: yoyo: support for new DBGI_SRAM region")
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Link: https://lore.kernel.org/r/iwlwifi.20220129105618.209f3078bc74.I463530bd2f40daedb39f6d9df987bb7cee209033@changeid
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 --
    drivers/net/wireless/intel/iwlwifi/iwl-prph.h | 2 --
    2 files changed, 4 deletions(-)

    diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
    index a39013c401c9..e2001e88a4b4 100644
    --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
    +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
    @@ -1562,8 +1562,6 @@ iwl_dump_ini_dbgi_sram_iter(struct iwl_fw_runtime *fwrt,
    return -EBUSY;

    range->range_data_size = reg->dev_addr.size;
    - iwl_write_prph_no_grab(fwrt->trans, DBGI_SRAM_TARGET_ACCESS_CFG,
    - DBGI_SRAM_TARGET_ACCESS_CFG_RESET_ADDRESS_MSK);
    for (i = 0; i < (le32_to_cpu(reg->dev_addr.size) / 4); i++) {
    prph_data = iwl_read_prph(fwrt->trans, (i % 2) ?
    DBGI_SRAM_TARGET_ACCESS_RDATA_MSB :
    diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-prph.h b/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
    index a84ab02cf9d7..7d3fedfdb348 100644
    --- a/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
    +++ b/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
    @@ -356,8 +356,6 @@
    #define WFPM_GP2 0xA030B4

    /* DBGI SRAM Register details */
    -#define DBGI_SRAM_TARGET_ACCESS_CFG 0x00A2E14C
    -#define DBGI_SRAM_TARGET_ACCESS_CFG_RESET_ADDRESS_MSK 0x10000
    #define DBGI_SRAM_TARGET_ACCESS_RDATA_LSB 0x00A2E154
    #define DBGI_SRAM_TARGET_ACCESS_RDATA_MSB 0x00A2E158

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 15:22    [W:4.055 / U:1.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site