lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0531/1017] scsi: pm8001: Fix command initialization in pm8001_chip_ssp_tm_req()
    Date
    From: Damien Le Moal <damien.lemoal@opensource.wdc.com>

    [ Upstream commit cd2268a180117aa8ebb23e090ba204324b2d0e93 ]

    The ds_ads_m field of struct ssp_ini_tm_start_req has the type __le32.
    Assigning a value to it should thus use cpu_to_le32(). This fixes the
    sparse warning:

    warning: incorrect type in assignment (different base types)
    expected restricted __le32 [addressable] [assigned] [usertype] ds_ads_m
    got int

    Link: https://lore.kernel.org/r/20220220031810.738362-7-damien.lemoal@opensource.wdc.com
    Fixes: dbf9bfe61571 ("[SCSI] pm8001: add SAS/SATA HBA driver")
    Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
    Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/pm8001/pm8001_hwi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
    index f364495ab40e..eca1ab198314 100644
    --- a/drivers/scsi/pm8001/pm8001_hwi.c
    +++ b/drivers/scsi/pm8001/pm8001_hwi.c
    @@ -4637,7 +4637,7 @@ int pm8001_chip_ssp_tm_req(struct pm8001_hba_info *pm8001_ha,
    memcpy(sspTMCmd.lun, task->ssp_task.LUN, 8);
    sspTMCmd.tag = cpu_to_le32(ccb->ccb_tag);
    if (pm8001_ha->chip_id != chip_8001)
    - sspTMCmd.ds_ads_m = 0x08;
    + sspTMCmd.ds_ads_m = cpu_to_le32(0x08);
    circularQ = &pm8001_ha->inbnd_q_tbl[0];
    ret = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &sspTMCmd,
    sizeof(sspTMCmd), 0);
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 15:22    [W:2.201 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site