lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0314/1017] soc: qcom: aoss: Fix missing put_device call in qmp_get
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 4b41a9d0fe3db5f91078a380f62f0572c3ecf2dd ]

    The reference taken by 'of_find_device_by_node()' must be released when
    not needed anymore.
    Add the corresponding 'put_device()' in the error handling paths.

    Fixes: 8c75d585b931 ("soc: qcom: aoss: Expose send for generic usecase")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Stephen Boyd <swboyd@chromium.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220108095931.21527-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/qcom_aoss.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
    index 34acf58bbb0d..e234d78b33e7 100644
    --- a/drivers/soc/qcom/qcom_aoss.c
    +++ b/drivers/soc/qcom/qcom_aoss.c
    @@ -451,7 +451,11 @@ struct qmp *qmp_get(struct device *dev)

    qmp = platform_get_drvdata(pdev);

    - return qmp ? qmp : ERR_PTR(-EPROBE_DEFER);
    + if (!qmp) {
    + put_device(&pdev->dev);
    + return ERR_PTR(-EPROBE_DEFER);
    + }
    + return qmp;
    }
    EXPORT_SYMBOL(qmp_get);

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 14:54    [W:2.225 / U:2.848 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site