lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0202/1017] selinux: check return value of sel_make_avc_files
    Date
    From: Christian Göttsche <cgzones@googlemail.com>

    [ Upstream commit bcb62828e3e8c813b6613db6eb7fd9657db248fc ]

    sel_make_avc_files() might fail and return a negative errno value on
    memory allocation failures. Re-add the check of the return value,
    dropped in 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table").

    Reported by clang-analyzer:

    security/selinux/selinuxfs.c:2129:2: warning: Value stored to
    'ret' is never read [deadcode.DeadStores]
    ret = sel_make_avc_files(dentry);
    ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~

    Fixes: 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table")
    Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    [PM: description line wrapping, added proper commit ref]
    Signed-off-by: Paul Moore <paul@paul-moore.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    security/selinux/selinuxfs.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
    index e4cd7cb856f3..f2f6203e0fff 100644
    --- a/security/selinux/selinuxfs.c
    +++ b/security/selinux/selinuxfs.c
    @@ -2127,6 +2127,8 @@ static int sel_fill_super(struct super_block *sb, struct fs_context *fc)
    }

    ret = sel_make_avc_files(dentry);
    + if (ret)
    + goto err;

    dentry = sel_make_dir(sb->s_root, "ss", &fsi->last_ino);
    if (IS_ERR(dentry)) {
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 14:16    [W:2.679 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site