lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0167/1017] crypto: rsa-pkcs1pad - restore signature length check
    Date
    From: Eric Biggers <ebiggers@google.com>

    commit d3481accd974541e6a5d6a1fb588924a3519c36e upstream.

    RSA PKCS#1 v1.5 signatures are required to be the same length as the RSA
    key size. RFC8017 specifically requires the verifier to check this
    (https://datatracker.ietf.org/doc/html/rfc8017#section-8.2.2).

    Commit a49de377e051 ("crypto: Add hash param to pkcs1pad") changed the
    kernel to allow longer signatures, but didn't explain this part of the
    change; it seems to be unrelated to the rest of the commit.

    Revert this change, since it doesn't appear to be correct.

    We can be pretty sure that no one is relying on overly-long signatures
    (which would have to be front-padded with zeroes) being supported, given
    that they would have been broken since commit c7381b012872
    ("crypto: akcipher - new verify API for public key algorithms").

    Fixes: a49de377e051 ("crypto: Add hash param to pkcs1pad")
    Cc: <stable@vger.kernel.org> # v4.6+
    Cc: Tadeusz Struk <tadeusz.struk@linaro.org>
    Suggested-by: Vitaly Chikunov <vt@altlinux.org>
    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    crypto/rsa-pkcs1pad.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/crypto/rsa-pkcs1pad.c
    +++ b/crypto/rsa-pkcs1pad.c
    @@ -538,7 +538,7 @@ static int pkcs1pad_verify(struct akciph

    if (WARN_ON(req->dst) ||
    WARN_ON(!req->dst_len) ||
    - !ctx->key_size || req->src_len < ctx->key_size)
    + !ctx->key_size || req->src_len != ctx->key_size)
    return -EINVAL;

    req_ctx->out_buf = kmalloc(ctx->key_size + req->dst_len, GFP_KERNEL);

    \
     
     \ /
      Last update: 2022-04-05 14:14    [W:4.278 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site