lkml.org 
[lkml]   [2022]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0219/1017] selftests/x86: Add validity check and allow field splitting
    Date
    From: Muhammad Usama Anjum <usama.anjum@collabora.com>

    [ Upstream commit b06e15ebd5bfb670f93c7f11a29b8299c1178bc6 ]

    Add check to test if CC has a string. CC can have multiple sub-strings
    like "ccache gcc". Erorr pops up if it is treated as single string and
    double quotes are used around it. This can be fixed by removing the
    quotes and not treating CC as a single string.

    Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection")
    Reported-by: "kernelci.org bot" <bot@kernelci.org>
    Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
    Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
    Link: https://lkml.kernel.org/r/20220214184109.3739179-2-usama.anjum@collabora.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/x86/check_cc.sh | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh
    index 3e2089c8cf54..8c669c0d662e 100755
    --- a/tools/testing/selftests/x86/check_cc.sh
    +++ b/tools/testing/selftests/x86/check_cc.sh
    @@ -7,7 +7,7 @@ CC="$1"
    TESTPROG="$2"
    shift 2

    -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
    +if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then
    echo 1
    else
    echo 0
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-04-05 14:14    [W:4.020 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site