lkml.org 
[lkml]   [2022]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: v5.18-rc1: migratepages triggers VM_BUG_ON_FOLIO(folio_nr_pages(old) != nr_pages)
Date
On 4 Apr 2022, at 12:06, Matthew Wilcox wrote:

> On Mon, Apr 04, 2022 at 11:44:39AM -0400, Zi Yan wrote:
>> I am wondering if my change is the right fix or not. folios with order>0
>> are still available when CONFIG_TRANSPARENT_HUGEPAGE is not set, right?
>
> That's the eventual plan, but it's not possible today. We need to
> be able to split large folios (eg in truncation) and that functionality
> is still under CONFIG_TRANSPARENT_HUGEPAGE in mm/huge_memory.c. So
> large folios depend on CONFIG_TRANSPARENT_HUGEPAGE instead of having a
> clean separation between functionality-to-support-PMD-mapping and
> functionality-to-support-order>0.
>
> So I preferred your earlier patch because it's more obvious. I mean,
> we could pull in the two or three patches from my tree that convert
> these functions and their callers to folios ... we're only at rc1.
> I can post them and see what others think.

OK, I will send out my initial patch.

--
Best Regards,
Yan, Zi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-04-05 00:32    [W:0.078 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site